-
Notifications
You must be signed in to change notification settings - Fork 20.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core, eth, ethstats: simplify chain head events #30601
Conversation
Are we emitting these chain events in the downloader on snap sync as well? If so I would vote to remove it, if it is only on full sync, I would kinda understand that it could be useful for someone, but still the usefulness is so marginal, that I would remove it |
I agree about removing the heavy blocks, and reducing the subscription throughput. But then I'm not a consumer of these subscriptions, and can't really say whether this will break someone's usecase. |
@fjl any thoughts? |
8fd6c3d
to
bc315ff
Compare
I've reverted the last commit until we figure it out. The rest of the PR is essentially a noop cleanup. It is not observable from the outside in any way shape or form. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Chain events currently pass blocks everywhere. Which is funky, because the first thing all receivers do is extract out the headers and throw the block away :). This PR changes all the event content to only pass the headers around.
Open quetsions:
Reverted the below change until we figure it out:
This is the crux of the PR, the rest is just fixing up the fallout: