core: minor fix for the log wrapper with debug purpose #30454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaraWang
requested review from
karalabe,
holiman and
rjl493456442
as code owners
CaraWang
force-pushed
the
carawang/fix/log-for-debug
branch
from
815b8aa
to
3610460
Compare
|
IMO these should all just be removed instead of updated. No reason to have commented debug-logging code in the codebase. |
Thank you for your response. =) At first glance, I thought it was a bad smell. But it's helpful when I need to debug and fix the test cases, so I think it might be helpful for someone else someday. It's okay if these codes should be removed. I can also help remove them in this PR. I will wait for a couple of hours to see if others have different opinions. |
rjl493456442
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR, #28187, the way to set the default logger is different. This PR only updates the way to set logger in some test cases' comments that existed in the codebase (since this commit b63e3c37a6). Although I am not sure if it a good way to leave the code in the comment, it truly makes me more efficiently to debug and fix the failing test cases.