eth/tracers/live: run supply tests off of generated artifacts #30451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
requested review from
lightclient,
gballet,
karalabe,
holiman and
rjl493456442
as code owners
holiman
reviewed
Nov 20, 2024
There was a problem hiding this comment.
I'm pushing some changes. For one thing, the names, instead of
=== RUN TestSupplyTracerBlockchain/omittedFields/omitted_fields_cancun
=== PAUSE TestSupplyTracerBlockchain/omittedFields/omitted_fields_cancun
=== RUN TestSupplyTracerBlockchain/selfdestruct/selfdestruct_cancun
=== PAUSE TestSupplyTracerBlockchain/selfdestruct/selfdestruct_cancun
=== RUN TestSupplyTracerBlockchain/selfdestructItselfAndRevert/selfdestruct_itself_and_revert_grayGlacier
I think it's better to leave the filenames as is:
=== RUN TestSupplyTracerBlockchain/omitted_fields.json/omitted_fields_cancun
=== PAUSE TestSupplyTracerBlockchain/omitted_fields.json/omitted_fields_cancun
=== RUN TestSupplyTracerBlockchain/selfdestruct.json/selfdestruct_cancun
=== PAUSE TestSupplyTracerBlockchain/selfdestruct.json/selfdestruct_cancun
=== RUN TestSupplyTracerBlockchain/selfdestruct_itself_and_revert.json/selfdestruct_itself_and_revert_grayGlacier
That way, when investigating a failure, it's easier to figure out what the source is. Instead of having to first figure out to un-camel it and add .json suffix.
Comment on lines
+539
to
+510
| // IsParis returns whether the given block is either equal to the Paris (merge) | ||
| // fork or greater. | ||
| // Note: Only usable for post-merge networks where MergeNetsplitBlock has been configured. |
There was a problem hiding this comment.
Wait...
- returns whether the given block is either
>= merge, - only usable for
> merge-networks
??
holiman
force-pushed
the
livetracer-test-runner
branch
from
20ae72c to
f59f77f
Compare
holiman
approved these changes
Nov 20, 2024
holiman
requested changes
Nov 20, 2024
|
@s1na needs a rebase |
|
I've approved it already, but it needs a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the block test format used for consensus testing is also ideal for testing live tracers. I have taken our existing tests for the supply tracer and turned them into a filler binary + a dumb test runner that takes processes the json files. I believe this format can be re-used for other live tracers (with the exception of the
"except"field which would be different).The only thorn in my side is the filler. I've put it as an executable module right now in
eth/tracers/live/tests.