cmd/utils,p2p: enable discv5 by default #30327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Aug 20, 2024
Comment on lines
+550
to
+552
| if err := t.handlePacket(from, buf[:nbytes]); err != nil && unhandled == nil { | ||
| t.log.Debug("Bad discv4 packet", "addr", from, "err", err) | ||
| } else if err != nil && unhandled != nil { |
There was a problem hiding this comment.
This changes the semantics. Previously, if there was an error, we did the log.Debug unconditioally. Now we only do if it unhandled == nil.
Shouldn't you do something like this?
Suggested change
| if err := t.handlePacket(from, buf[:nbytes]); err != nil && unhandled == nil { | |
| t.log.Debug("Bad discv4 packet", "addr", from, "err", err) | |
| } else if err != nil && unhandled != nil { | |
| if err := t.handlePacket(from, buf[:nbytes]); err != nil { | |
| t.log.Debug("Bad discv4 packet", "addr", from, "err", err) | |
| if unhandled != nil { |
There was a problem hiding this comment.
Right so that was actually the goal. Every discv5 message goes through unhandled, which means every discv5 message causes a "Bad discv4 packet" log to print. That doesn't seem correct.
holiman
approved these changes
Aug 20, 2024
fjl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #30302 is in, I think we enable discv5 by default.