Add eth_necessaryGas to restore eth_estimateGas behavior #29727
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29726 by keeping eth_estimateGas broken in favor of a new method that forces precision.
Fixes documentation for eth_estimateGas to signal its current behavior.
IMO eth_estimateGas should be correct and the faster version should be the non-standard method. eth_estimateGas has defined behavior:
However if geth can truly single-handledly change the specification of ethjsonrpc, then I am powerless to stop them. Instead I create a new method, eth_necessaryGas to implement the defined behavior of eth_estimateGas.
But a more ethical fix would be to revert the PR that introduced ErrorRatio.