cmd/utils, core: Ensure Dev Mode Genesis TTD/Difficulty are 0 #29566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
requested review from
karalabe,
holiman and
rjl493456442
as code owners
…hat developer genesis block ttd == difficulty == 0.
|
Oops. (other than the validation I add here), this has already been done in #29469 . |
jwasinger
changed the title
jwasinger
force-pushed
the
dev-genesis-difficulty
branch
from
0e55ebf
to
ffeaf04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #29404 , dev mode will fail to start up when a custom genesis is used because of this check:
We now default the dev genesis TTD to 0, which also technically makes it the last block before the merge. However, post-merge timestamp-activated forks are activated at genesis. Withdrawals also still seem to work. It's a weird situation all-around and I'm not sure what the ramifications are.