Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/state: check err for iter.Error in fastDeleteStorage #28122

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

darioush
Copy link
Contributor

Hi. It seems the intention was to check the error returned from iter.Error() and return it if non-nil.
Thanks.

@darioush darioush changed the title core/state: check err for iter.Error core/state: check err for iter.Error in fastDeleteStorage Sep 15, 2023
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@rjl493456442 rjl493456442 added this to the 1.13.1 milestone Sep 15, 2023
@rjl493456442 rjl493456442 merged commit 48fdb79 into ethereum:master Sep 15, 2023
1 check passed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants