Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: remove invocations of strings.Title #26711

Closed
wants to merge 3 commits into from
Closed

all: remove invocations of strings.Title #26711

wants to merge 3 commits into from

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Feb 16, 2023

This is a follow-up to #26710, removing the deprecated strings.Title(foo), and replacing it with cases.Title(language.English).String(foo).

@fjl
Copy link
Contributor

fjl commented Feb 16, 2023

I think the deprecation of strings.Title is stupid. Having to import a much larger package just to turn lowercase ASCII into uppercase ASCII sucks. That's why I added the exclude rule.

@holiman
Copy link
Contributor Author

holiman commented Feb 16, 2023

@fjl ok

@holiman holiman closed this Feb 16, 2023
@holiman holiman mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl Awaiting requested review from fjl fjl will be requested when the pull request is marked ready for review fjl is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi will be requested when the pull request is marked ready for review zsfelfoldi is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 will be requested when the pull request is marked ready for review rjl493456442 is a code owner

@karalabe karalabe Awaiting requested review from karalabe karalabe will be requested when the pull request is marked ready for review karalabe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holiman @fjl