common/prque: generic priority queue #26286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
requested review from
zsfelfoldi,
rjl493456442 and
holiman
as code owners
holiman
reviewed
Dec 1, 2022
Whaaaa, maybe I didn't update my submodules to whatever was on master? |
karalabe
force-pushed
the
generic-prque
branch
from
d251cef
to
04e7f0f
Compare
karalabe
force-pushed
the
generic-prque
branch
from
04e7f0f
to
ee6c890
Compare
|
@holiman Fixed, PTAL |
fjl
reviewed
Dec 1, 2022
| type Prque struct { | ||
| cont *sstack | ||
| type Prque[V any] struct { | ||
| cont *sstack[V] |
There was a problem hiding this comment.
I think we could have parameters P comparable, V any here. That way, one could use any integer type as key.
There was a problem hiding this comment.
LES uses some weird "wrap around" notion for the priorities, which requires subtracting one priority from another. @zsfelfoldi said that that is a temporary hack 2 years ago :P Until that's fixed, I can't make the priority "comparable" only.
There was a problem hiding this comment.
This would be the code to make the priority generic too: #26290, but it changes LES in - a probably silently - breaking way. We need a fix / confirm frmo @zsfelfoldi to make this change.
fjl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts
common/prqueto generics and does the necessary refactors to have the code use the new style.There are two instances in our code:
downloader.queue.expireandtrie.Syncwhere I couldn't properly convert because we add 2 different types of items into the same queue:downloader.queue.expireis a generic method that's called on different queue types, but there's no way to have typed method, limitation of go.