Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/geth: set EnableBashCompletion = true #24313

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Conversation

ligi
Copy link
Member

@ligi ligi commented Jan 30, 2022

context #24145

image

maybe we should also add it for other commands - so far I only enabled it for geth

@karalabe
Copy link
Member

Can this auto complete flags though? That's the relevant thing really, commands are super rare.

@ligi
Copy link
Member Author

ligi commented Jan 31, 2022

It currently does not support flags - but as for this comment urfave/cli#351 (comment) it could be extended to support flags

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karalabe karalabe added this to the 1.10.16 milestone Feb 2, 2022
@ligi ligi removed the status:triage label Feb 8, 2022
@holiman holiman modified the milestones: 1.10.16, 1.10.17 Feb 16, 2022
@ligi ligi added the pr:merge label Mar 15, 2022
@holiman holiman merged commit 6cd7266 into ethereum:master Mar 15, 2022
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Mar 16, 2022
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this pull request May 26, 2022
cp-wjhan pushed a commit to cp-yoonjin/go-wemix that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants