cmd/utils: open db in readonly when dev datadir exists #24298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Jan 28, 2022
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #24119 introduced a regression where if the specified datadir for dev mode didn't exist geth wouldn't start. #24281 fixed that regression.
In this PR we add an extra check to see if the datadir exists. If so, then the db is opened in read-only. Otherwise it's opened in write-mode so leveldb can create the relevant files. Note that this is not the live db that dev mode uses for its operations. It's only opened temporarily to check for existence of a genesis block and closed immediately and hence doesn't need write access.