Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accounts/abi/bind: fix incorrect error handling #23781

Merged
merged 1 commit into from
Oct 21, 2021
Merged

accounts/abi/bind: fix incorrect error handling #23781

merged 1 commit into from
Oct 21, 2021

Conversation

kibgzr
Copy link
Contributor

@kibgzr kibgzr commented Oct 21, 2021

Panic when HeaderByNumber() returns an error.

MariusVanDerWijden
MariusVanDerWijden approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, whoopsi

@fjl fjl merged commit b6fb184 into ethereum:master Oct 21, 2021
@fjl fjl added this to the 1.10.12 milestone Oct 21, 2021
@holiman holiman changed the title fix error handling incorrect acconts/api/bind: fix incorrect error handling Oct 21, 2021
@fjl fjl changed the title acconts/api/bind: fix incorrect error handling accounts/abi/bind: fix incorrect error handling Oct 21, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Oct 21, 2021
@kibgzr
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
2944633 
This fixes a panic that occurs when HeaderByNumber() returns an error.
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
@kibgzr @zzyalbert
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
31e77dd 
This fixes a panic that occurs when HeaderByNumber() returns an error.
@gzliudan gzliudan mentioned this pull request May 30, 2024
Open
19 tasks
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
1ba3d1f 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 19, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
ffaa146 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 21, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
c89152b 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 22, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
8f9ae76 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 23, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
641c7fe 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 24, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
7238ad8 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
5cfb1c6 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
f7edfdb 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
ef1640d 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
963b1b4 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
fd13cfc 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
1054628 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
aa0cfaf 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
f9d8014 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
7293cd1 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
6ed6bad 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 10, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
9831388 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
340ba7b 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
c5446f4 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
dc55c81 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
4e79b1a 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
fa155c8 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
19973ff 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
7b334f1 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
7cc9d4d 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
22c3ba0 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
eec8ced 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
c4bdbe8 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
add41ac 
This fixes a panic that occurs when HeaderByNumber() returns an error.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@kibgzr @gzliudan
accounts/abi/bind: fix error handling in baseFee query (ethereum#23781)
668e5db 
This fixes a panic that occurs when HeaderByNumber() returns an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.12
Development

Successfully merging this pull request may close these issues.
3 participants
@kibgzr @MariusVanDerWijden @fjl