Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "eth, internal/ethapi: make RPC block miner field show block sealer correctly" #23466

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Aug 25, 2021

Reverts #23312

See #23463

The rpc returndata uses a field miner, but does not otherwise contain coinbase. Thus, if the caller wants to calculate the header/block hash on the remote side, it's impossible to do so since we do not provide the correct coinbase any longer.

Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.10.9 milestone Aug 26, 2021
@holiman holiman merged commit 62ad17f into master Aug 26, 2021
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Aug 26, 2021
paouvrard added a commit to aurora-is-near/rainbow-bridge-client that referenced this pull request Sep 22, 2021
paouvrard added a commit to aurora-is-near/rainbow-bridge-client that referenced this pull request Sep 22, 2021
@holiman holiman deleted the revert-23312-master branch October 20, 2021 12:00
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants