Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/ethapi: fix transaction APIs #23179

Merged
merged 4 commits into from
Jul 13, 2021
Merged

internal/ethapi: fix transaction APIs #23179

merged 4 commits into from
Jul 13, 2021

Conversation

rjl493456442
Copy link
Member

This PR fixes the stale checks in some transaction APIs. Previously the gasPrice field is required for signing transaction. After the london the gasPrice can be replaced with the MaxFeePerGas and MaxPriorityFeePerGas combo. So the check
should be changed accordingly.

fjl
fjl reviewed Jul 8, 2021
View reviewed changes
internal/ethapi/api.go Outdated Show resolved Hide resolved
@lightclient
Copy link
Member

cc @kclowes

@karalabe karalabe added this to the 1.10.5 milestone Jul 13, 2021
karalabe
karalabe approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit 846badc into ethereum:master Jul 13, 2021
@fselmo fselmo mentioned this pull request Jul 14, 2021
Closed
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Jul 28, 2021
@rjl493456442
internal/ethapi: fix transaction APIs (ethereum#23179)
c414f29 
* internal/ethapi: fix transaction APIs

* internal/ethapi: fix typo

* internal/ethapi: address comments

* internal/ethapi: address comment from Peter
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
@rjl493456442 @atif-konasl
internal/ethapi: fix transaction APIs (ethereum#23179)
9f308b9 
* internal/ethapi: fix transaction APIs

* internal/ethapi: fix typo

* internal/ethapi: address comments

* internal/ethapi: address comment from Peter
This was referenced Sep 23, 2022
Closed
Merged
@gzliudan gzliudan mentioned this pull request Jun 13, 2024
Open
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
ff72c35
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
b63180a
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 19, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
848b862
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 21, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
c3796cf
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 22, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
d8f4ad2
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 23, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
8d17856
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 24, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
4a5bd31
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
62c2cf1
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
e082add
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
2394b5c
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
3931681
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
608dc47
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
494797c
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
20f0114
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
657f5ed
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
bd7bb45
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
13926b0
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
882e744
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
c739ae4
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
c4af3e7
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
7cfe35b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
436d523
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
288025f
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
6067031
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
7948eb4
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
5e4292b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
125008b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
17c7436
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
1433787
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@gzliudan
internal/ethapi: fix transaction APIs (ethereum#23179)
2e28dd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl left review comments

@holiman holiman holiman left review comments

@lightclient lightclient lightclient left review comments

@karalabe karalabe karalabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.5
Development

Successfully merging this pull request may close these issues.
5 participants
@rjl493456442 @lightclient @fjl @karalabe @holiman