Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 #23028

Merged
merged 1 commit into from
Jun 10, 2021
Merged

eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 #23028

merged 1 commit into from
Jun 10, 2021

Conversation

karalabe
Copy link
Member

Make sure we don't limit the gas estimation to below the actual block size.

@karalabe karalabe added this to the 1.10.4 milestone Jun 10, 2021
rjl493456442
rjl493456442 approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

It's kind of a moving target. Right now the mainnet gaslimit is 15m so after the 1559 the maximum can be 30m. If miners choose to bump again, the maximum can be larger.

@karalabe karalabe merged commit 1fc0eba into ethereum:master Jun 10, 2021
@holiman
Copy link
Contributor

holiman commented Jun 10, 2021

I think we should bump it more. Originally when we set 25M, the gas limit was around 8 or 10. The limit was comfortably larger than the block gas limit, and exists just to prevent trivial DoS.

@gzliudan gzliudan mentioned this pull request May 17, 2024
Open
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
13946ee 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
73965d2 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
ce65327 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 19, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
7b2c2e5 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 21, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
ffe5735 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 22, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
a4ac209 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 23, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
0bc9af1 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 24, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
4490db1 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
0a6ee68 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
de86baa 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
128fadb 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
3bf417b 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
2d8fb2e 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
5d10458 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
36b39c0 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
f47fe6c 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
4825d53 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
d7861bb 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
81137da 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
f4b1b38 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
7af69f5 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
ac8942e 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
bc88aa4 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
07e8850 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
04faee5 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
8b6e6f7 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
753061c 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
732a797 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
96a2c70 
…hereum#23028)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@gzliudan
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 (et…
a02c942 
…hereum#23028)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@holiman holiman Awaiting requested review from holiman holiman is a code owner

Assignees
No one assigned
Labels
london
Projects
None yet
Milestone
1.10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@karalabe @holiman @rjl493456442