core/rawdb: db inspect move 'config' and 'shutdown' into 'meta data' #22978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evolution404
requested review from
holiman,
karalabe and
rjl493456442
as code owners
rjl493456442
reviewed
Jun 1, 2021
| @@ -369,8 +370,6 @@ func InspectDatabase(db ethdb.Database, keyPrefix, keyStart []byte) error { | |||
| bytes.HasPrefix(key, []byte("bltIndex-")) || | |||
| bytes.HasPrefix(key, []byte("bltRoot-")): // Bloomtrie sub | |||
| bloomTrieNodes.Add(size) | |||
| case bytes.Equal(key, uncleanShutdownKey): | |||
| shutdownInfo.Add(size) | |||
There was a problem hiding this comment.
Please also count it in the meta.
There was a problem hiding this comment.
It has been counted in the default 😂
rjl493456442
approved these changes
Jun 1, 2021
|
LGTM, but the linter complains: It needs a |
Evolution404
commented
Jun 1, 2021
| unaccounted stat | ||
| shutdownInfo stat | ||
| metadata stat | ||
| unaccounted stat |
There was a problem hiding this comment.
But I didn't modify these two line, how would this happen?😂
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
…thereum#22978) * core/rawdb: db inspect move 'config' and 'shutdown' into 'meta data' * gofmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the error message of Database contains
unaccounted data