Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: define London+baikal, undefine yolov3, add london override flag #22822

Merged
merged 2 commits into from
May 6, 2021
Merged

all: define London+baikal, undefine yolov3, add london override flag #22822

merged 2 commits into from
May 6, 2021

Conversation

holiman
Copy link
Contributor

@holiman holiman commented May 5, 2021 •
edited
Loading

This PR

  • removes berlinOverride flag, and adds londonOverride flag instead
  • removes yolov3, and adds baikal
  • Adds londonBlock to the configuration
  • Defines baikal config to have the londonBlock set

I think it's better if we don't use e.g. baikalBlock and yolov3Block, but instead define the network baikal as having londonBlock.

If we merge this, we can enable the other baikal/london eips through the mechanics defined here

karalabe
karalabe approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.10.4 milestone May 6, 2021
@karalabe karalabe merged commit cc606be into ethereum:master May 6, 2021
@holiman holiman added the london label May 6, 2021
@holiman holiman mentioned this pull request May 6, 2021
Closed
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
@holiman @atif-konasl
all: define London+baikal, undefine yolov3, add london override flag (e…
3f4b261 
…thereum#22822)

* all: define London+baikal, undefine yolov3, add london override flag

* cmd, core, params: add baikal genesis definition
This was referenced Sep 23, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

Assignees
No one assigned
Labels
london
Projects
None yet
Milestone
1.10.4
Development

Successfully merging this pull request may close these issues.
2 participants
@holiman @karalabe