Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: use golang.org/x/sys/unix to support Solaris #22584

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

dokterbob
Copy link
Contributor

Ref: golang/go#11113

Fixes ../../ethereum/go-ethereum@v1.9.21/metrics/cpu_syscall.go:30:12: undefined: syscall.Getrusage (amongst others)

dokterbob added a commit to dokterbob/coreth that referenced this pull request Mar 26, 2021
@fjl
Copy link
Contributor

fjl commented Mar 26, 2021

I think it's a bit much to replace it everywhere. The specific issue seems to be with metrics/cpu_syscall.go, so we only need to fix it there.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl merged commit 2dee319 into ethereum:master Jun 1, 2021
@fjl fjl changed the title Replace syscall by sys/unix, support Solaris etc. metrics: use golang.org/x/sys/unix to support Solaris Jun 1, 2021
@fjl fjl added this to the 1.10.4 milestone Jun 1, 2021
@fjl fjl removed the status:triage label Jun 1, 2021
@dokterbob dokterbob deleted the syscall_replace branch June 16, 2021 15:11
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
Fixes ethereum#11113

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 10, 2024
Fixes ethereum#11113

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 10, 2024
Fixes ethereum#11113

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 13, 2024
Fixes ethereum#11113

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Dec 16, 2024
Fixes ethereum#11113

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Dec 16, 2024
Fixes ethereum#11113

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Dec 20, 2024
Fixes ethereum#11113

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Dec 20, 2024
Fixes ethereum#11113

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Dec 22, 2024
Fixes ethereum#11113

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Jan 2, 2025
Fixes ethereum#11113

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants