eth: fix snap sync cancellation #22334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
approved these changes
Feb 16, 2021
|
Unfortunately snap can't reference the downloader as that would be a dep loop. I think this is fine, we can drop fast sync after snap, so one cancellation will get deleted and imho the other is not needed, but don't want to touch it now. |
This was referenced Mar 9, 2021
Closed
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22179 introduced a slight regression when defining a new
errCancellederror for snap sync. Whilst differentiating success from cancellation might be necessary, the downloader specifically handled state cancellations, which the new cancellation type broke. This PR just ensures that the downloader reacts the same way to snap and fast sync terminations.