core: fix temp memory blowup caused by defers holding on to state #22319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I think you didn't select this PR run on the charts, I only see the reference which blew :) |
|
Ah, you compared vs previous runs. |
|
Blue-green = master
|
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding the background trie prefetcher, I've used defers to make sure the prefetchers are stopped irrelevant what error path the importer exits on. Learnt once again that defer in a loop is a horrible idea, because it kept references to old state imported in the same batch. On the Shanghai attack range, this caused a temporary memory blowup, which if enough blocks were imported in a single batch could cause a significant RAM spike.
Shoutout to Michael for finding this issue.