rpc: increase the number of subscriptions in storm test #22316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
force-pushed
the
freebsd-fix-storm-test
branch
from
8c3d26b
to
d49f0e1
Compare
holiman
approved these changes
Feb 15, 2021
filipescuc
pushed a commit
to EthereumGenesys/go-ethereum
that referenced
this pull request
Mar 2, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22314.
The
TestClientNotificationStormtest checks that a storm of client notification subscriptions is detected and an error is returned. For whatever reason, FreeBSD seems to handle the storm a tiny bit better than other systems, and therefore no error is raised. Bumping the number of requests by 1000 causes the expected buffer flood and an error is correctly reported.