Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access list state test format #22290

Merged
merged 11 commits into from
Mar 3, 2021
Merged

Access list state test format #22290

merged 11 commits into from
Mar 3, 2021

Conversation

MariusVanDerWijden
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden commented Feb 8, 2021 •
edited
Loading

Updates marshalling and execution for the new access list format in the state tests

depends on #21502

@MariusVanDerWijden MariusVanDerWijden mentioned this pull request Feb 10, 2021
Closed
4 tasks
@holiman
Copy link
Contributor

holiman commented Feb 17, 2021

On this PR, are you able to execute the tests in ethereum/tests#774 ?

@holiman
Copy link
Contributor

holiman commented Feb 19, 2021

Rebased

@holiman
Copy link
Contributor

holiman commented Feb 19, 2021 

[user@work evm]$ ./evm statetest ../../tests/testdata/GeneralStateTests/stEIP2930/addressOpcodes.json 
json: cannot unmarshal string into Go struct field stJSON.transaction of type tests.stData

@MariusVanDerWijden MariusVanDerWijden added this to the 1.10.0 milestone Feb 25, 2021
@MariusVanDerWijden MariusVanDerWijden marked this pull request as ready for review February 25, 2021 10:12
@MariusVanDerWijden
Copy link
Member Author

It passes the newest version (ethereum/tests@0966f56) of the ethereum/tests flawlessly!

@holiman
Copy link
Contributor

holiman commented Feb 25, 2021

Obviously this will need a rebase, and it's a bit hard to see the changes -- but did you add the new tests? If not, please add the updated tests (or maybe wait until they've been merged to master)

@MariusVanDerWijden
Copy link
Member Author

Didn't add the tests yet, will do once they merge

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
Access list state test format (ethereum#22290)
10a40e4
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
Access list state test format (ethereum#22290)
ab8456d
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 19, 2024
@gzliudan
Access list state test format (ethereum#22290)
b9d8544
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 21, 2024
@gzliudan
Access list state test format (ethereum#22290)
eec7cdc
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 22, 2024
@gzliudan
Access list state test format (ethereum#22290)
54f1b8a
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 23, 2024
@gzliudan
Access list state test format (ethereum#22290)
f97fe56
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 24, 2024
@gzliudan
Access list state test format (ethereum#22290)
a98d827
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
Access list state test format (ethereum#22290)
25f50e0
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
Access list state test format (ethereum#22290)
992cd03
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
Access list state test format (ethereum#22290)
fda8413
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
Access list state test format (ethereum#22290)
4b6b04f
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
Access list state test format (ethereum#22290)
8b8c573
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
Access list state test format (ethereum#22290)
2438663
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
Access list state test format (ethereum#22290)
6100a29
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
Access list state test format (ethereum#22290)
8285667
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
Access list state test format (ethereum#22290)
6853ebc
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
Access list state test format (ethereum#22290)
39783bf
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
Access list state test format (ethereum#22290)
73fedd3
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
Access list state test format (ethereum#22290)
cbd27aa
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
Access list state test format (ethereum#22290)
452c156
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
Access list state test format (ethereum#22290)
fb58483
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
Access list state test format (ethereum#22290)
1b5527a
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@gzliudan
Access list state test format (ethereum#22290)
709f58b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
Access list state test format (ethereum#22290)
7e52efb
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
Access list state test format (ethereum#22290)
87126a8
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
Access list state test format (ethereum#22290)
1451f38
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
Access list state test format (ethereum#22290)
acaf984
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
Access list state test format (ethereum#22290)
286d762
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
Access list state test format (ethereum#22290)
5ebc0b6
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@gzliudan
Access list state test format (ethereum#22290)
b269441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gballet gballet Awaiting requested review from gballet

@holiman holiman Awaiting requested review from holiman

@karalabe karalabe Awaiting requested review from karalabe

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MariusVanDerWijden @holiman @fjl