trie : use trie.NewStackTrie instead of new(trie.Trie)

[ucwong]

No description provided.

[fjl]

@holiman @karalabe: I just noticed, through this PR, that we added the hasher parameter in 87c0ba9. I think it would be better to remove this parameter again and let NewBlock handle this internally.

[ucwong]

@holiman @karalabe: I just noticed, through this PR, that we added the hasher parameter in 87c0ba9. I think it would be better to remove this parameter again and let NewBlock handle this internally.

It will cause import cycle for this stacktrie_test.go file
https://github.com/ethereum/go-ethereum/blob/master/trie/stacktrie_test.go#L12

[holiman]

Yes, makes definite sense to me

[holiman]

@holiman @karalabe: I just noticed, through this PR, that we added the hasher parameter in 87c0ba9. I think it would be better to remove this parameter again and let NewBlock handle this internally.

I'd love to get rid of it, but if so we need to solve the import cycle problem. ISTR it's not just tests, but other things that are hard to solve

[karalabe]

Stack trie assume we insert sorted keys, right? Are we sure all these use cases do that?

[holiman]

Stack trie assume we insert sorted keys, right? Are we sure all these use cases do that?

Yes, it does. However, all these usecases, unless I've missed something, is used (eventually) to feed into DeriveSha, which (nowadays) ensure that the keys are sorted.

If I missed something, then that would be bad :/

[holiman]

LGTM. This PR changes to use stackTrie in places that either directly call into DeriveSha, or types.NewBlock, where the hasher is only used for call into DeriveSha.