common/mclock: remove dependency on github.com/aristanetworks/goarista #22211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It takes three lines of code to get to runtime.nanotime, no need to pull a dependency for that.
MariusVanDerWijden
approved these changes
Jan 22, 2021
There was a problem hiding this comment.
LGTM, goarista had an empty .s file to prevent this issue: golang/go#15006 but I don't think we need that anymore
|
I think we do need that, I just forgot to commit |
bulgakovk
pushed a commit
to bulgakovk/go-ethereum
that referenced
this pull request
Jan 26, 2021
ethereum#22211) It takes three lines of code to get to runtime.nanotime, no need to pull a dependency for that.
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It takes three lines of code to get to runtime.nanotime, no need to pull a dependency for that.