graphql: return decimal for estimateGas and cumulativeGas queries
#22126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGKSK8LIFE
approved these changes
Jan 6, 2021
GregTheGreek
approved these changes
Jan 6, 2021
atoulme
approved these changes
Jan 6, 2021
Ivshti
approved these changes
Jan 6, 2021
pedrouid
reviewed
Jan 6, 2021
| @@ -811,15 +811,15 @@ type CallData struct { | |||
| // CallResult encapsulates the result of an invocation of the `call` accessor. | |||
| type CallResult struct { | |||
| data hexutil.Bytes // The return data from the call | |||
| gasUsed hexutil.Uint64 // The amount of gas used | |||
| gasUsed Long // The amount of gas used | |||
zscole
approved these changes
Jan 6, 2021
| @@ -301,21 +301,21 @@ func (t *Transaction) Status(ctx context.Context) (*hexutil.Uint64, error) { | |||
| return &ret, nil | |||
| } | |||
|
|
|||
| func (t *Transaction) GasUsed(ctx context.Context) (*hexutil.Uint64, error) { | |||
| func (t *Transaction) GasUsed(ctx context.Context) (*Long, error) { | |||
| receipt, err := t.getReceipt(ctx) | ||
| if err != nil || receipt == nil { | ||
| return nil, err | ||
| } | ||
| ret := hexutil.Uint64(receipt.GasUsed) | ||
| ret := Long(receipt.GasUsed) |
| receipt, err := t.getReceipt(ctx) | ||
| if err != nil || receipt == nil { | ||
| return nil, err | ||
| } | ||
| ret := hexutil.Uint64(receipt.CumulativeGasUsed) | ||
| ret := Long(receipt.CumulativeGasUsed) |
| @@ -811,15 +811,15 @@ type CallData struct { | |||
| // CallResult encapsulates the result of an invocation of the `call` accessor. | |||
| type CallResult struct { | |||
| data hexutil.Bytes // The return data from the call | |||
| gasUsed hexutil.Uint64 // The amount of gas used | |||
| gasUsed Long // The amount of gas used | |||
There was a problem hiding this comment.
i'd like to speak to the manager
| @@ -811,15 +811,15 @@ type CallData struct { | |||
| // CallResult encapsulates the result of an invocation of the `call` accessor. | |||
| type CallResult struct { | |||
| data hexutil.Bytes // The return data from the call | |||
| gasUsed hexutil.Uint64 // The amount of gas used | |||
| gasUsed Long // The amount of gas used | |||
| @@ -117,6 +117,12 @@ func TestGraphQLBlockSerialization(t *testing.T) { | |||
| want: `{"errors":[{"message":"Cannot query field \"bleh\" on type \"Query\".","locations":[{"line":1,"column":2}]}]}`, | |||
| code: 400, | |||
| }, | |||
| // should return `estimateGas` as decimal | |||
| { | |||
| body: `{"query": "{block{ estimateGas(data:{}) }}"}`, | |||
There was a problem hiding this comment.
|
Woah, I didn't evne comment and this got merged. Gonna have to revert, sorry. |
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the return values for
estimateGasandcumulativeGasto decimal rather than hexadecimal, as defined by the spec.