eth, les: add new config "syncFromCheckpoint" #22123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
requested review from
holiman,
karalabe and
zsfelfoldi
as code owners
DGKSK8LIFE
approved these changes
Jan 6, 2021
zsfelfoldi
approved these changes
Jan 16, 2021
| @@ -21,6 +21,7 @@ func (c Config) MarshalTOML() (interface{}, error) { | |||
| NetworkId uint64 | |||
| SyncMode downloader.SyncMode | |||
| EthDiscoveryURLs []string | |||
| SnapDiscoveryURLs []string | |||
There was a problem hiding this comment.
Is this field added here by mistake? (if you really wanted to add it, it's fine, no need open another PR just for this change)
holiman
approved these changes
Jan 19, 2021
bulgakovk
pushed a commit
to bulgakovk/go-ethereum
that referenced
this pull request
Jan 26, 2021
This PR introduces a new config field SyncFromCheckpoint for light client. In some special scenarios, it's required to start synchronization from some arbitrary checkpoint or even from the scratch. So this PR offers this flexibility to users so that the synchronization start point can be configured. There are two relevant configs: SyncFromCheckpoint and Checkpoint. - If the SyncFromCheckpoint is true, the light client will try to sync from the specified checkpoint. - If the Checkpoint is not configured, then the light client will sync from the scratch(from the latest header if the database is not empty) Additional notes: these two configs are not visible in the CLI flags but only accessable in the config file. Example Usage: [Eth] SyncFromCheckpoint = true [Eth.Checkpoint] SectionIndex = 100 SectionHead = "0xabc" CHTRoot = "0xabc" BloomRoot = "0xabc" PS. Historical checkpoint can be retrieved from the synced full node or light client via les_getCheckpoint API.
9 tasks
9 tasks
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new config field
SyncFromCheckpointfor light client.In some special scenarios, it's required to start synchronization from some arbitrary checkpoint or even from the scratch. So this PR offers this flexibility to users so that the synchronization start point can be configured.
There are two relevant configs:
SyncFromCheckpointandCheckpoint.SyncFromCheckpointis true, the light client will try to sync from the specified checkpoint.Checkpointis not configured, then the light client will sync from the scratch(from the latest header if the database is not empty)Additional notes: these two configs are not visible in the CLI flags but only accessable in the config file.
Example Usage:
PS. Historical checkpoint can be retrieved from the synced full node or light client via
les_getCheckpointAPI.Fixes
#21786
#21337