cmd: support v1.1 Twitter API in faucet, fix puppeth #22107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
force-pushed
the
faucet-twitter
branch
from
495be99
to
e4571d8
Compare
DGKSK8LIFE
approved these changes
Jan 4, 2021
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twitter closed down their old website, which the faucet used to retrieve tweets from. This PR extends the faucet to support the old v1.1 API beside the newer v2 (not generally available yet) and fixes
puppethto support deploying the faucet again (is broken on master, the Dockerfile template is invalid). The PR also adds a readme to the faucet to help anyone else wishing to deploy it outside ofpuppeth.