Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/geth: fix import / export issues related to DB unavailability #21414

Merged
merged 6 commits into from
Aug 6, 2020
Merged

cmd/geth: fix import / export issues related to DB unavailability #21414

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d4e27d0
should fix import / export issues related to DB unavailability
renaynay Aug 5, 2020
13fa76f
document reason for makeConfigNode
renaynay Aug 5, 2020
b134490
fix comment
renaynay Aug 5, 2020
ab578b8
comment consistency
renaynay Aug 5, 2020
0351bd8
remove comments
renaynay Aug 5, 2020
0be45c5
lint
renaynay Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cmd/geth/chaincmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,8 @@ func importChain(ctx *cli.Context) error {
utils.SetupMetrics(ctx)
// Start system runtime metrics collection
go metrics.CollectProcessMetrics(3 * time.Second)
stack, _ := makeFullNode(ctx)
// make the bare-minimum node to avoid unnecessary service start-up
stack, _ := makeConfigNode(ctx)
defer stack.Close()

chain, db := utils.MakeChain(ctx, stack, false)
Expand Down Expand Up @@ -372,7 +373,8 @@ func exportChain(ctx *cli.Context) error {
if len(ctx.Args()) < 1 {
utils.Fatalf("This command requires an argument.")
}
stack, _ := makeFullNode(ctx)
// make the bare-minimum node to avoid unnecessary service start-up
stack, _ := makeConfigNode(ctx)
defer stack.Close()

chain, _ := utils.MakeChain(ctx, stack, true)
Expand Down