Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/ethapi: return revert reason for eth_call #21083

Merged
merged 26 commits into from
Jun 8, 2020
Merged

internal/ethapi: return revert reason for eth_call #21083

merged 26 commits into from
Jun 8, 2020

Commits on Jun 5, 2020

  1. internal/ethapi: return revert reason for eth_call

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    fd70cfe View commit details
    Browse the repository at this point in the history

  2. internal/ethapi: moved revert reason logic to doCall

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    6d13d42 View commit details
    Browse the repository at this point in the history

  3. accounts/abi/bind/backends: added revert reason logic to simulated ba… 

    …ckend
    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    23312e0 View commit details
    Browse the repository at this point in the history

  4. internal/ethapi: fixed linting error

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    05eb3d5 View commit details
    Browse the repository at this point in the history

  5. internal/ethapi: check if require reason can be unpacked

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    92bee6b View commit details
    Browse the repository at this point in the history

  6. internal/ethapi: better error logic

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    024e5a7 View commit details
    Browse the repository at this point in the history

  7. internal/ethapi: simplify logic

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    fbdc6bb View commit details
    Browse the repository at this point in the history

  8. internal/ethapi: return vmError()

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    9f8a0b5 View commit details
    Browse the repository at this point in the history

  9. internal/ethapi: move handling of revert out of docall

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    7b6fbca View commit details
    Browse the repository at this point in the history

  10. graphql: removed revert logic until spec change

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    ca35628 View commit details
    Browse the repository at this point in the history

  11. rpc: internal/ethapi: added custom error types

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    d77770d View commit details
    Browse the repository at this point in the history

  12. graphql: use returndata instead of return 

    Return() checks if there is an error. If an error is found, we return nil.
For most use cases it can be beneficial to return the output even if there
was an error. This code should be changed anyway once the spec supports
error reasons in graphql responses
    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    9f13c66 View commit details
    Browse the repository at this point in the history

  13. accounts/abi/bind/backends: added tests for revert reason

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    cc37ce7 View commit details
    Browse the repository at this point in the history

  14. internal/ethapi: add errorCode to revert error

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    d9b4bc7 View commit details
    Browse the repository at this point in the history

  15. internal/ethapi: add errorCode of 3 to revertError

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    304a63c View commit details
    Browse the repository at this point in the history

  16. internal/ethapi: unified estimateGasErrors, simplified logic

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    693db4d View commit details
    Browse the repository at this point in the history

  17. internal/ethapi: unified handling of errors in DoEstimateGas

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    5048fd1 View commit details
    Browse the repository at this point in the history

  18. rpc: print error data field

    @rjl493456442 @karalabe
    rjl493456442 authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    c7765c0 View commit details
    Browse the repository at this point in the history

  19. accounts/abi/bind/backends: unify simulatedBackend and RPC

    @rjl493456442 @karalabe
    rjl493456442 authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    4515f84 View commit details
    Browse the repository at this point in the history

  20. internal/ethapi: added binary data to revertError data

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    c9deb8a View commit details
    Browse the repository at this point in the history

  21. internal/ethapi: refactored unpacking logic into newRevertError

    @MariusVanDerWijden @karalabe
    MariusVanDerWijden authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    7cdf4ee View commit details
    Browse the repository at this point in the history

  22. accounts/abi/bind/backends: fix EstimateGas

    @rjl493456442 @karalabe
    rjl493456442 authored and karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    53508c5 View commit details
    Browse the repository at this point in the history

  23. accounts, console, internal, rpc: minor error interface cleanups

    @karalabe
    karalabe committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    2d3ef53 View commit details
    Browse the repository at this point in the history

  24. Revert "accounts, console, internal, rpc: minor error interface clean… 

    …ups"

This reverts commit 2d3ef53.
    @fjl
    fjl committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    5a62532 View commit details
    Browse the repository at this point in the history

  25. re-apply the good parts of 2d3ef53

    @fjl
    fjl committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    e5adaec View commit details
    Browse the repository at this point in the history

  26. rpc: add test for returning server error data from client

    @fjl
    fjl committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    440d603 View commit details
    Browse the repository at this point in the history