Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: close log file before calling truncate on windows #20556

Closed
wants to merge 1 commit into from
Closed

log: close log file before calling truncate on windows #20556

wants to merge 1 commit into from

Conversation

kukugi
Copy link

@kukugi kukugi commented Jan 14, 2020

If you truncate an open file in Windows, access is denied.
how about close the file before truncation?

@kukugi
log: close log file before calling truncate on windows
c4fb2d8 
   If you truncate an open file in Windows, access is denied.
   how about close the file before truncation?
@fjl
Copy link
Contributor

fjl commented Jan 21, 2020

We have decided to remove RotatingFileHandler instead of fixing it because the handler has other issues and is not used by go-ethereum. It is removed in PR #20586.

@fjl fjl closed this Jan 21, 2020
@fjl fjl removed the status:triage label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kukugi @fjl @adamschmideg