Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm: code cleanup. move to ethersphere/swarm #19661

Merged
merged 1 commit into from
Jun 4, 2019
Merged

swarm: code cleanup. move to ethersphere/swarm #19661

merged 1 commit into from
Jun 4, 2019

Conversation

skylenet
Copy link
Member

@skylenet skylenet commented Jun 4, 2019

Removing the swarm codebase from go-ethereum

New home is under ethersphere/swarm

@skylenet skylenet requested review from nonsense and karalabe June 4, 2019 12:35
@skylenet skylenet requested review from fjl, holiman, janos and zelig as code owners June 4, 2019 12:35
karalabe
karalabe reviewed Jun 4, 2019
View reviewed changes
.travis.yml Show resolved Hide resolved
karalabe
karalabe approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@karalabe karalabe added this to the 1.9.0 milestone Jun 4, 2019
@karalabe karalabe merged commit 42b81f9 into ethereum:master Jun 4, 2019
@nonsense
Copy link
Member

nonsense commented Jun 4, 2019

@karalabe has anyone optimized the running time of the go-ethereum test suite more than @skylenet ;)

@karalabe
Copy link
Member

karalabe commented Jun 4, 2019

@nonsense :trollface:

@holiman holiman mentioned this pull request Jun 18, 2019
Closed
come-maiz added a commit to come-maiz/geth-snap that referenced this pull request Jul 5, 2019
@come-maiz
Remove swarm
614bdbc 
swarm has been removed from the geth repo: ethereum/go-ethereum#19661
@sihoang sihoang mentioned this pull request Oct 21, 2019
Merged
@trinhdn2 trinhdn2 mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonsense nonsense nonsense approved these changes

@karalabe karalabe karalabe approved these changes

@fjl fjl Awaiting requested review from fjl fjl is a code owner

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@janos janos Awaiting requested review from janos

@zelig zelig Awaiting requested review from zelig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skylenet @nonsense @karalabe