Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/rawdb: keep genesis in key-value store for full sync too #19628

Merged
merged 1 commit into from
May 27, 2019

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented May 27, 2019

This is a counterpart to #19617 to ensure that the genesis block is never deleted from leveldb. The reasoning is that it's healthy to always know which network the database is on. It also fixes an issue in geth init that reset the freezer due to a missing genesis block in leveldb.

Fixes #19627.

@karalabe karalabe added this to the 1.9.0 milestone May 27, 2019
@karalabe karalabe requested a review from rjl493456442 May 27, 2019 09:29
@karalabe karalabe requested a review from holiman as a code owner May 27, 2019 09:29
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit db0cc21 into ethereum:master May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't freeze genesis block on full sync either
2 participants