Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: concurrent database reinit from freezer dump #19604

Merged
merged 3 commits into from
May 27, 2019

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented May 21, 2019

Our previous code reinitialized a new database from an old freezer sequentially. This turned out to be quite a heavy operation, taking 1h56m59.818s for mainnet. This PR attempts to make block and transaction hashing concurrent, reaching a reinit speed of 52m3.238s. That's kind of the limit of leveldb random inserts.

@karalabe karalabe requested a review from holiman as a code owner May 21, 2019 13:46
@karalabe karalabe requested a review from rjl493456442 May 21, 2019 13:46
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Curious how much it can speed up.

@karalabe karalabe force-pushed the freezer-reimport-fast branch from 6ff1580 to 0e5226c Compare May 27, 2019 11:47
@karalabe karalabe added this to the 1.9.0 milestone May 27, 2019
@karalabe karalabe merged commit fc85777 into ethereum:master May 27, 2019
@karalabe karalabe changed the title Freezer reimport fast core: concurrent database reinit from freezer dump May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants