internal/build: fix commit extraction for detached head repo #18315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
requested changes
Dec 19, 2018
fjl
changed the title
Requested in ethereum#18315
|
@fjl ping |
|
Up! |
4000D
pushed a commit
to tokamak-network/plasma-evm
that referenced
this pull request
Sep 16, 2019
* Fix commit extraction * Comments for commit extraction Requested in ethereum/go-ethereum#18315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your repository is in "detached HEAD state" when you compile project - commit hash is not detected automatically.
In this repo state
HEADfile contains just commit hash and not branch name. I propose to use this commit on build stage.