Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd, core, miner: add --txpool.locals and priority mining #17472

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Aug 21, 2018

This PR adds support for specifying local accounts via the CLI flag --txpool.locals (i.e. not requiring an RPC submission to mark something local). This allows nodes to pick up, track and journal local transactions that might have been submitted from a different remote node and arrived via devp2p.

The PR also adds support for prioritizing mining local transactions first and remote ones afterwards. It does it by simply splitting the set of pending transactions into locals and remotes and injecting the locals first, then the remotes.

@karalabe karalabe added this to the 1.8.14 milestone Aug 21, 2018
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo, otherwise LGTM

core/tx_pool.go Outdated
as.cache = nil
}

// flatten returns the list of addresses within this set, also cachng it for later
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cachng -> caching

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ghost
Copy link

ghost commented Aug 22, 2018

Ethereum Transaction Accelerator coming soon? xD
eth_acc

@karalabe karalabe merged commit 6a8b47c into ethereum:master Aug 22, 2018
@gzliudan gzliudan mentioned this pull request May 8, 2024
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants