Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fixed typo #17214

Merged
merged 2 commits into from
Jul 24, 2018
Merged

core: fixed typo #17214

merged 2 commits into from
Jul 24, 2018

Conversation

osuketh
Copy link
Contributor

@osuketh osuketh commented Jul 20, 2018

line133: fix "Minimum" to "Maximum".

@osuketh osuketh requested review from holiman and karalabe as code owners July 20, 2018 14:59
@GitCop
Copy link

GitCop commented Jul 20, 2018

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: eb57b15
  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

@osuketh osuketh changed the title core/tx_pool.go: fixed typo core/tx_pool: fixed typo Jul 20, 2018
@osuketh osuketh changed the title core/tx_pool: fixed typo core: fixed typo Jul 20, 2018
karalabe
karalabe requested changes Jul 23, 2018
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both minimum and maximum are wrong. The correct statement would be "Number of executable transaction slots guaranteed per account"

@GitCop
Copy link

GitCop commented Jul 24, 2018

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: eb57b15
  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

@karalabe karalabe added this to the 1.8.13 milestone Jul 24, 2018
@karalabe karalabe merged commit 10780e8 into ethereum:master Jul 24, 2018
firmianavan pushed a commit to firmianavan/go-ethereum that referenced this pull request Aug 28, 2018
@osuketh @firmianavan
core: fix txpool guarantee comment (ethereum#17214)
8fd0734 
* fixed-typo

* core: fix txpool guarantee comment
@gzliudan gzliudan mentioned this pull request May 8, 2024
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request May 9, 2024
@gzliudan
core: fixed typo (ethereum#17214)
241201c
@gzliudan gzliudan mentioned this pull request May 17, 2024
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

@holiman holiman Awaiting requested review from holiman holiman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.13
Development

Successfully merging this pull request may close these issues.
3 participants
@osuketh @GitCop @karalabe