Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/vm: make contract creation failed if address collisions #15038

Closed
wants to merge 1 commit into from
Closed

core/vm: make contract creation failed if address collisions #15038

wants to merge 1 commit into from

Conversation

rjl493456442
Copy link
Member

Implements ethereum EIP689

@karalabe
Copy link
Member

Please ping us before you start working on something, especially on metropolis stuff with deadlines. I already have this implemented locally, just debating consensus issues between different implementations.

@karalabe
Copy link
Member

Otherwise the code is ok :)

@karalabe
Copy link
Member

Actually, not fully ok. Anyway, there's a cornercase that needs to be figured out before we can finalize this. ethereum/pm#21 (comment)

@rjl493456442
Copy link
Member Author

It is fine. I will close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjl493456442 @karalabe