Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-16 JSON RPC DoS vulnerability for large messages #418

Closed
Gustav-Simonsson opened this issue Mar 3, 2015 · 2 comments
Closed

SEC-16 JSON RPC DoS vulnerability for large messages #418

Gustav-Simonsson opened this issue Mar 3, 2015 · 2 comments
Milestone

Comments

@Gustav-Simonsson
Copy link

The current JSON-RPC framework does not limit maximum size of requests.

STATUS: FIXED

@obscuren obscuren modified the milestone: Frontier Mar 9, 2015
@obscuren
Copy link
Contributor

obscuren commented Mar 9, 2015

I wonder what a reasonable size is.

obscuren added a commit that referenced this issue Mar 9, 2015
@obscuren
Copy link
Contributor

obscuren commented Mar 9, 2015

Right now set to 1024*1024

@obscuren obscuren closed this as completed Mar 9, 2015
AusIV pushed a commit to NoteGio/go-ethereum that referenced this issue Jan 18, 2022
…urns-node-errors

Add return of node errors in trace_block
tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this issue Jan 20, 2022
maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue Dec 9, 2022
Increased default value of rpc.txfeecap to 5
garyschulte pushed a commit to garyschulte/go-ethereum that referenced this issue Apr 17, 2024
* simplified gas accounting layer

* integrate some review feedback

* Apply suggestions from code review

Co-authored-by: Ignacio Hagopian <jsign.uy@gmail.com>

* more suggestions from code review

* don't charge creation gas + charge code chunks in create

* A couple more fixes

* make linter happy

* fix create init gas consumption issue

* fix: in gas funcs, use tx witness instead of global witness

* fix linter issue

* Apply suggestions from code review

Co-authored-by: Ignacio Hagopian <jsign.uy@gmail.com>

* fix: EXTCODECOPY gas consumption

* fix warm gas costs

* fix the order gas is charged in during contract creation epilogue

* fix selfdestruct

* fix ethereum#365 in eip rewrite (ethereum#407)

* fix: OOG type in code creation OOG (ethereum#408)

* core/vm: charge BLOCKHASH witness cost (ethereum#409)

* core/vm: charge BLOCKHASH witness cost

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* remove gas optimization for now

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

---------

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* remove redundant logic for contract creation (ethereum#413)

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* fix precompile address check for charging witness costs & fix missing value-bearing rule (ethereum#412)

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* core/vm: fix wrong check (ethereum#416)

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* charge for account creation if selfdestruct creates a new account (ethereum#417)

* add key comparison test (ethereum#418)

* core/vm: charge contract init before execution logic (ethereum#419)

* core/vm: charge contract init before execution logic

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* fix CREATE2 as well

---------

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>

* quell linter

---------

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Co-authored-by: Ignacio Hagopian <jsign.uy@gmail.com>
mralj pushed a commit to NethermindEth/rollup-geth that referenced this issue Nov 18, 2024
s1na pushed a commit to s1na/go-ethereum that referenced this issue Dec 2, 2024
Dev upgrade Merge from Auditing Change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants