Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newline from description field in setup.cfg #395

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

petertdavies
Copy link
Collaborator

What was wrong?

There is a newline in the description field in setup.cfg. This is illegal, but was only caught by python buildtools in after a recent patch.

How was it fixed?

Removed the newline.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

Codecov Report

Merging #395 (8e0440e) into master (8e8379d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   94.92%   94.92%           
=======================================
  Files          46       46           
  Lines        2522     2522           
=======================================
  Hits         2394     2394           
  Misses        128      128           
Flag Coverage Δ
unittests 94.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8379d...8e0440e. Read the comment docs.

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ultratwo this is also addressed in #394

@SamWilsn SamWilsn merged commit ecee7e0 into ethereum:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants