Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): EIP-7702: Remove delegation behavior of EXTCODE* #984

Merged
merged 3 commits into from
Dec 5, 2024
Merged

fix(tests): EIP-7702: Remove delegation behavior of EXTCODE* #984

merged 3 commits into from
Dec 5, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Dec 2, 2024 •
edited
Loading

🗒️ Description

Addresses changes in ethereum/EIPs#8969

Requires ethereum/execution-specs#1042

@petertdavies

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added the scope:tests Scope: Changes EL client test cases in `./tests` label Dec 2, 2024
@marioevz marioevz changed the title Eip 7702 remove ext code delegation behavior fix(tests): EIP-7702: Remove delegation behavior of EXTCODE* Dec 2, 2024
@danceratopz danceratopz added the fork:prague Prague hardfork label Dec 3, 2024
@spencer-tb spencer-tb mentioned this pull request Dec 3, 2024
Open
spencer-tb
spencer-tb approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I understand :D

@marioevz marioevz merged commit d65e6fb into main Dec 5, 2024
5 checks passed
@marioevz marioevz deleted the eip-7702-remove-ext-code-delegation-behavior branch December 5, 2024 17:22
codeofcarson pushed a commit to codeofcarson/execution-spec-tests that referenced this pull request Jan 24, 2025
@marioevz @codeofcarson
fix(tests): EIP-7702: Remove delegation behavior of EXTCODE* (ethereu…
67bf4a7 
…m#984)

* fix(tests): EIP-7702: Update behavior on ext*code

* fix(tests): EIP-7702: Update behavior on ext*code gas tests (use CALL)

* docs: Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-tb spencer-tb spencer-tb approved these changes

Assignees
No one assigned
Labels
fork:prague Prague hardfork scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marioevz @spencer-tb @danceratopz