Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): Explicit test for EXTDELEGATECALL value cost #911

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Oct 23, 2024

🗒️ Description

There has been divergence in EXTDELEGATECALL implementations, whereby effectively non-zero value call (non-zero value coming from an outer EXTCALL!) was charging an additional 9000. C.f. EIP update for background: ethereum/EIPs#8990, in this PR we give extra emphasis that the additional cost, and other value-related rules, are only relevant to EXTCALL.

Unfortunately, due to the 63/64th rule on calls, I had to complicate gas_test.py an additional bit :/.

EDIT: Note that all 3 EXT*CALL can, and are tested the same way, for completeness (see comment below)

🔗 Related Issues

NA, reported on discord. We did have a test which covered this, but without an explicit post state assertion.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@pdobacz pdobacz requested a review from shemnon October 23, 2024 16:02
@pdobacz pdobacz self-assigned this Oct 23, 2024
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, thanks!

tests/osaka/eip7692_eof_v1/eip7069_extcall/test_gas.py Outdated Show resolved Hide resolved
@pdobacz pdobacz merged commit 358a26f into ethereum:main Oct 28, 2024
3 checks passed
@pdobacz pdobacz deleted the update7069 branch October 28, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants