new(tests): Explicit test for EXTDELEGATECALL value cost #911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
There has been divergence in EXTDELEGATECALL implementations, whereby effectively non-zero value call (non-zero value coming from an outer EXTCALL!) was charging an additional 9000. C.f. EIP update for background: ethereum/EIPs#8990, in this PR we give extra emphasis that the additional cost, and other value-related rules, are only relevant to EXTCALL.
Unfortunately, due to the 63/64th rule on calls, I had to complicate
gas_test.py
an additional bit :/.EDIT: Note that all 3 EXT*CALL can, and are tested the same way, for completeness (see comment below)
🔗 Related Issues
NA, reported on discord. We did have a test which covered this, but without an explicit post state assertion.
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.