-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tests): EIP-7685: Return Engine API error code for invalid params #1097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for ethereum/execution-apis#622!
I don't see how it adds coverage for ethereum/execution-apis#623? But it's late 😆
Co-authored-by: danceratopz <danceratopz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how it adds coverage for ethereum/execution-apis#623? But it's late 😆
Thanks for the aysnc heads up, this is covered here:
Lines 443 to 452 in 7270a51
# - Duplicate request tests | |
for request_type, (eoa_request, block_request) in all_request_types.items(): | |
combinations.append( | |
pytest.param( | |
[eoa_request], | |
Requests(block_request).requests_list * 2, | |
BlockException.INVALID_REQUESTS, | |
id=f"duplicate_{request_type}_request", | |
), | |
) |
LGTM!
…ethereum#1097) * fix(tests): EIP-7685: Return Engine API error code for invalid params * chore(tests): improve fixture docstring * Update tests/prague/eip7685_general_purpose_el_requests/conftest.py Co-authored-by: danceratopz <danceratopz@gmail.com> --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
…ethereum#1097) * fix(tests): EIP-7685: Return Engine API error code for invalid params * chore(tests): improve fixture docstring * Update tests/prague/eip7685_general_purpose_el_requests/conftest.py Co-authored-by: danceratopz <danceratopz@gmail.com> --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
🗒️ Description
Updates EIP-7685 to take into account the following execution-apis PRs:
engine_newPayloadV4
for Prague execution-apis#622🔗 Related Issues
#1094
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.