convert calldatacopy test

[pacrob]

🗒️ Description

Converts calldatacopy tests from here

Questions:

• I'm not sure why tests before Byzantium are failing.
• If the file is to be deleted from ethereum/tests, how should I reference the source in the docstring?
• I'm not sure how to address the coverage CI failure. I tried running it locally but didn't get any more clarifying info from it.

🔗 Related Issues

✅ Checklist

• All: Set appropriate labels for the changes.
• All: Considered squashing commits to improve commit history.
• All: Added an entry to CHANGELOG.md.
• All: Considered updating the online docs in the ./docs/ directory.
• Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
• Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
• Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

[marioevz]

Thanks for this! I've left some comments to make the code more readable, I can fully review once these are applied 👍

[marioevz]

Can be rewritten as:

Suggested change

	Op.PUSH1[0x2]
	+ Op.PUSH1[0x1]
	+ Op.PUSH1[0x0]
	+ Op.CALLDATACOPY
	Op.CALLDATACOPY(dest_offset=0, offset=1, size=2)

Improves readability a bit IMO.

[marioevz]

Suggested change

	+ Op.MSIZE
	+ Op.PUSH1[0x0]
	+ Op.RETURN
	+ Op.RETURN(offset=0, size=Op.MSIZE)

Also here and for the rest of the bytecodes.

[marioevz]

This can be removed because RETURN is a terminating opcode, and if the test gets automatically converted to EOF it could be annoying.

Suggested change

+ Op.STOP

[marioevz]

Suggested change

	to_address_storage: Account,
	to_address_storage: Account | None,

From some of the parametrized values.

[marioevz]

I think this and most if not all lines above can be rewritten using parentheses like Op.CALL(0xFFFFFF, Op.ADD( ....

[marioevz]

I think this amount of balance might be unnecessary.

A bit of background is that this value was common in ethereum/tests, but now we can use the execute command to send these transactions to a live network, and if we use this amount the pre-deploy account has to be funded with this. So it's better to keep it to the minimum necessary.

[marioevz]

Suggested change

nonce=0x00,

Can be removed since the sender that is returned by pre.fund_eoa() has a nonce counter that is automatically increased and used for each transaction that is generated with it.

[marioevz]

I think this also can be reduced due to similar reason as the balance of the contract.

Suggested change

	gas_limit=0x04C4B400,
	gas_limit=100_000,

[marioevz]

Questions:

• I'm not sure why tests before Byzantium are failing.

This could potentially be due to the protected field in the transaction, since I think the transactions can only be protected on Byzantium and afterwards. You can try protected=fork>=Byzantium in the transaction building call (requires adding fork: Fork as parameter to the test function, and importing Fork from ethereum_test_forks).

• If the file is to be deleted from ethereum/tests, how should I reference the source in the docstring?

We could use the permalink to the file: https://github.com/ethereum/tests/blob/ae4791077e8fcf716136e70fe8392f1a1f1495fb/src/GeneralStateTestsFiller/VMTests/vmTests/calldatacopyFiller.yml

• I'm not sure how to address the coverage CI failure. I tried running it locally but didn't get any more clarifying info from it.

This might be because of the way the code is compiled for the ethereum/tests version of the test, so there's a difference between the opcodes used, but we could analyze the result and if deemed unimportant we can merge as is, no problem.