Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): EIP-7685: Remove outdated test, add more tests #1050

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jan 2, 2025

🗒️ Description

Fix empty list tests where the tests were hard-coding the hash to be invalid, but the invalidity was only true for the previous hash calculation method.

Add more tests and also future-proof (or at least fail test generation) in case there is a new request type introduced by a future fork.

Thanks to @rkrasiuk for finding this outdated test case!

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added type:bug Something isn't working scope:tests Scope: Changes EL client test cases in `./tests` type:test Type: Add/refactor fw unit tests; no fw or el client test case changes labels Jan 2, 2025
@marioevz
Copy link
Member Author

marioevz commented Jan 2, 2025

Generated fixtures (only for EIP-7685) here:
fixtures-updated-eip-7685.tar.gz

@marioevz marioevz force-pushed the fix-devnet-5-tests branch from 41495b6 to fe641f2 Compare January 9, 2025 17:05
@marioevz marioevz requested a review from danceratopz January 9, 2025 17:06
@marioevz
Copy link
Member Author

marioevz commented Jan 9, 2025

Rebased and renamed to parametrize_by_fork.

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Definitely a parametrize_by_fork enjoyor.

@marioevz marioevz merged commit 943e8de into main Jan 10, 2025
21 checks passed
@marioevz marioevz deleted the fix-devnet-5-tests branch January 10, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Changes EL client test cases in `./tests` type:bug Something isn't working type:test Type: Add/refactor fw unit tests; no fw or el client test case changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants