Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests): EIP-2537: Add G2 MSM test for max discount #1038

Merged
merged 2 commits into from
Jan 10, 2025
Merged

new(tests): EIP-2537: Add G2 MSM test for max discount #1038

merged 2 commits into from
Jan 10, 2025

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Dec 19, 2024 •
edited
Loading

🗒️ Description

Adds a test that should use the full discount table for G2 MSM.

Requires #1037 Merged

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz marked this pull request as draft December 19, 2024 19:43
@marioevz marioevz requested a review from winsvega December 19, 2024 19:44
@marioevz marioevz added the scope:tests Scope: Changes EL client test cases in `./tests` label Dec 19, 2024
@marioevz marioevz force-pushed the max-discount-msm-test branch from 2b4fb30 to a707406 Compare December 27, 2024 22:56
@marioevz marioevz marked this pull request as ready for review December 27, 2024 22:58
@marioevz marioevz merged commit aff955b into main Jan 10, 2025
5 checks passed
@marioevz marioevz deleted the max-discount-msm-test branch January 10, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winsvega winsvega winsvega approved these changes

Assignees
No one assigned
Labels
scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marioevz @winsvega