Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forks,specs,tests): EIP-7691, EIP-4844: Refactor to use dynamic parameters #1023

Merged
merged 13 commits into from
Jan 10, 2025

Conversation

marioevz
Copy link
Member

🗒️ Description

This PR removes activation of EIP-7742 at Prague, but leaves the framework changes.

Adds EIP-7691 Blob throughput increase by making a refactor of EIP-4844 tests to accept dynamic parameters during test generation.

This PR requires #1019.

🔗 Related Issues

#956

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz force-pushed the eip-7691 branch 2 times, most recently from b9da8eb to aeb1922 Compare December 17, 2024 23:22
@danceratopz danceratopz added type:feat type: Feature fork:prague Prague hardfork scope:tests Scope: Changes EL client test cases in `./tests` labels Dec 19, 2024
@marioevz marioevz force-pushed the eip-7691 branch 2 times, most recently from b0ad9e2 to 38a74aa Compare January 2, 2025 20:58
@marioevz
Copy link
Member Author

marioevz commented Jan 9, 2025

Rebased to main and fixed parametrize_by_fork marker rename.

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, @marioevz! I tried but failed to verify the Cancun fixtures (via hasher) due to the changes in many of the test ids - we should work on trying to the parameter ordering in the ids more deterministic. The cancun fixtures do at least all run against geth (1.14.9-stable-c350d3ac) though.

Approved, but perhaps merge #1069 and rebase on top of that to keep a clean state on main?

@marioevz
Copy link
Member Author

Approved, but perhaps merge #1069 and rebase on top of that to keep a clean state on main?

Rebased 🫡

Will merge once the tests pass, thanks!

@marioevz marioevz merged commit edbace1 into main Jan 10, 2025
22 checks passed
@marioevz marioevz deleted the eip-7691 branch January 10, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:prague Prague hardfork scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants