-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forks,specs,tests): EIP-7691, EIP-4844: Refactor to use dynamic parameters #1023
Conversation
b9da8eb
to
aeb1922
Compare
b0ad9e2
to
38a74aa
Compare
Rebased to main and fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, @marioevz! I tried but failed to verify the Cancun fixtures (via hasher
) due to the changes in many of the test ids - we should work on trying to the parameter ordering in the ids more deterministic. The cancun fixtures do at least all run against geth (1.14.9-stable-c350d3ac) though.
Approved, but perhaps merge #1069 and rebase on top of that to keep a clean state on main
?
…c blob parameters
Rebased 🫡 Will merge once the tests pass, thanks! |
🗒️ Description
This PR removes activation of EIP-7742 at Prague, but leaves the framework changes.
Adds EIP-7691 Blob throughput increase by making a refactor of EIP-4844 tests to accept dynamic parameters during test generation.
This PR requires #1019.
🔗 Related Issues
#956
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.