Engine API: narrow down fcU skip conditions #244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering the following EL block tree:
Current spec allows to skip processing in following cases:
fcU(head: A2.blockHash)
,fcU(head: A1.blockHash)
-- ancestors of the head of canonical chainfcU(head: B2.blockHash)
-- ancestor of a tip of another chain (not a leaf)After this change, the spec disallows to skip
fcU(head: B2.blockHash)
. For instance, whenBeaconBlock(B3)
appeared to be invalid but theB3
itself isVALID
, and then the network re-orgs toBeaconBlock(B2)
the EL must handle such a re-org properly and start a build process if requested.TODO:
Thanks to @rjl493456442 for helping to identify this issue.
H/t @djrtwo for the review