Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new evmc::result constructor #77

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Use new evmc::result constructor #77

merged 1 commit into from
Sep 18, 2019

Conversation

chfast
Copy link
Member

@chfast chfast commented Jun 27, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 27, 2019

Codecov Report

Merging #77 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   99.64%   99.64%   -0.01%     
==========================================
  Files           5        5              
  Lines         850      839      -11     
  Branches      111      109       -2     
==========================================
- Hits          847      836      -11     
  Partials        3        3

@axic
Copy link
Member

axic commented Sep 12, 2019

@chfast can this be done for 0.2?

@chfast
Copy link
Member Author

chfast commented Sep 17, 2019

Rebased. I think we can include this.

@chfast chfast marked this pull request as ready for review September 17, 2019 16:08
@axic
Copy link
Member

axic commented Sep 17, 2019

Is this speed critical though? Could this influence benchmarks a lot?

@chfast
Copy link
Member Author

chfast commented Sep 17, 2019

Is this speed critical though? Could this influence benchmarks a lot?

It should not matter - EVMC is doing the same thing except it checks the result of malloc(). Benchmarks show not performance difference.

@chfast chfast merged commit 6067254 into master Sep 18, 2019
@chfast chfast deleted the evmc_cpp_result branch September 18, 2019 06:30
jwasinger pushed a commit to jwasinger/evmone that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants