Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stack height validation for CALLF #594

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Conversation

rodiazet
Copy link
Collaborator

Enabling stack height validation requires passing EOF1Header to callf function context.

lib/evmone/baseline.hpp Outdated Show resolved Hide resolved
@chfast chfast added the EOF label Mar 23, 2023
@rodiazet rodiazet force-pushed the analyze-eof-refactor branch 2 times, most recently from 8814293 to 1036b0c Compare March 24, 2023 10:22
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need two unit tests for each check.

lib/evmone/instructions.hpp Outdated Show resolved Hide resolved
lib/evmone/baseline.hpp Outdated Show resolved Hide resolved
lib/evmone/instructions.hpp Outdated Show resolved Hide resolved
@rodiazet rodiazet force-pushed the analyze-eof-refactor branch 3 times, most recently from f16a0c7 to e86c78f Compare March 24, 2023 17:26
lib/evmone/baseline.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #594 (2dac2d7) into master (fd018f8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
+ Coverage   97.09%   97.11%   +0.01%     
==========================================
  Files          74       74              
  Lines        7395     7443      +48     
==========================================
+ Hits         7180     7228      +48     
  Misses        215      215              
Flag Coverage Δ
blockchaintests 63.55% <5.88%> (-0.17%) ⬇️
statetests 63.02% <5.88%> (-0.10%) ⬇️
unittests 93.97% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/evmone/eof.hpp 100.00% <ø> (ø)
lib/evmone/baseline.cpp 100.00% <100.00%> (ø)
lib/evmone/baseline.hpp 100.00% <100.00%> (ø)
lib/evmone/eof.cpp 82.36% <100.00%> (+0.04%) ⬆️
lib/evmone/instructions.hpp 100.00% <100.00%> (ø)
test/unittests/evm_eof_function_test.cpp 100.00% <100.00%> (ø)

lib/evmone/instructions.hpp Outdated Show resolved Hide resolved
lib/evmone/instructions.hpp Show resolved Hide resolved
@rodiazet rodiazet merged commit f835186 into master Mar 29, 2023
@rodiazet rodiazet deleted the analyze-eof-refactor branch March 29, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants