Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on EVMC instructions #533

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Remove dependency on EVMC instructions #533

merged 1 commit into from
Nov 30, 2022

Conversation

rodiazet
Copy link
Collaborator

No description provided.

@rodiazet rodiazet requested a review from chfast November 29, 2022 13:12
@rodiazet rodiazet force-pushed the evmc-dependency-removing branch 2 times, most recently from ff3aee4 to 62a5436 Compare November 29, 2022 18:55
@codecov
Copy link

codecov bot commented Nov 29, 2022 •
edited
Loading

Codecov Report

Merging #533 (4416a4f) into master (698e019) will not change coverage.
The diff coverage is n/a.

❗ Current head 4416a4f differs from pull request most recent head 919a932. Consider uploading reports for the commit 919a932 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #533   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files          59       59           
  Lines        5682     5682           
=======================================
  Hits         5570     5570           
  Misses        112      112
Flag Coverage Δ
blockchaintests 78.38% <ø> (ø)
statetests 72.91% <ø> (ø)
unittests 91.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chfast chfast changed the title Remove evmc dependency Remove dependency on EVMC instructions Nov 30, 2022
chfast
chfast reviewed Nov 30, 2022
View reviewed changes
lib/evmone/CMakeLists.txt Outdated Show resolved Hide resolved
lib/evmone/instructions_opcodes.hpp Outdated Show resolved Hide resolved
chfast
chfast reviewed Nov 30, 2022
View reviewed changes
lib/evmone/tracing.cpp Outdated Show resolved Hide resolved
test/unittests/evm_test.cpp Outdated Show resolved Hide resolved
@rodiazet rodiazet force-pushed the evmc-dependency-removing branch 4 times, most recently from 8b3302c to 5277fd0 Compare November 30, 2022 12:14
@rodiazet rodiazet marked this pull request as ready for review November 30, 2022 12:22
@rodiazet rodiazet requested a review from chfast November 30, 2022 12:22
chfast
chfast requested changes Nov 30, 2022
View reviewed changes
lib/evmone/baseline.cpp Outdated Show resolved Hide resolved
lib/evmone/instructions_opcodes.hpp Outdated Show resolved Hide resolved
test/unittests/evm_test.cpp Outdated Show resolved Hide resolved
lib/evmone/instructions.hpp Outdated Show resolved Hide resolved
test/utils/bytecode.hpp Outdated Show resolved Hide resolved
chfast
chfast requested changes Nov 30, 2022
View reviewed changes
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In CMake: remove evmc::instructions dependency from evmone and testutils.

chfast
chfast requested changes Nov 30, 2022
View reviewed changes
lib/evmone/baseline.cpp Outdated Show resolved Hide resolved
test/utils/bytecode.hpp Outdated Show resolved Hide resolved
@rodiazet rodiazet merged commit 83ad7bc into master Nov 30, 2022
@rodiazet rodiazet deleted the evmc-dependency-removing branch November 30, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodiazet @chfast